From: Gustavo Martin Morcuende <gu.martinm@gmail.com>
Date: Fri, 2 Dec 2016 21:18:03 +0000 (+0100)
Subject: Closing fd as it must be done in CustomHTTPClient
X-Git-Url: https://git.gumartinm.name/?a=commitdiff_plain;h=f3b8c903faf8516f316b14c3c88f041f03d60eb4;p=JavaForFun

Closing fd as it must be done in CustomHTTPClient

I feel ashame... :(
---

diff --git a/Allgemeines/RxJava/src/main/java/de/rxjava/tests/httpclient/CustomHTTPClient.java b/Allgemeines/RxJava/src/main/java/de/rxjava/tests/httpclient/CustomHTTPClient.java
index d639b03..0c7b510 100644
--- a/Allgemeines/RxJava/src/main/java/de/rxjava/tests/httpclient/CustomHTTPClient.java
+++ b/Allgemeines/RxJava/src/main/java/de/rxjava/tests/httpclient/CustomHTTPClient.java
@@ -35,12 +35,15 @@ public class CustomHTTPClient {
         try {
             connection.setRequestProperty("User-Agent", userAgent);
             connection.setRequestProperty("Cache-Control", "no-cache");
-            final InputStream in = new BufferedInputStream(connection.getInputStream());
-            final ByteArrayOutputStream buffer = readInputStream(in);
-            // No easy way of retrieving the charset from urlConnection.getContentType()
-            // Currently OpenWeatherMap returns: application/json; charset=utf-8
-            // Let's hope they will not change the content-type :/
-            return new String(buffer.toByteArray(), Charset.forName("UTF-8"));
+            
+            try (final InputStream in = new BufferedInputStream(connection.getInputStream());
+            	 final ByteArrayOutputStream buffer = readInputStream(in)) {
+            	
+	            // No easy way of retrieving the charset from urlConnection.getContentType()
+	            // Currently OpenWeatherMap returns: application/json; charset=utf-8
+	            // Let's hope they will not change the content-type :/
+	            return new String(buffer.toByteArray(), Charset.forName("UTF-8"));
+        	}
         } finally {
             connection.disconnect();
         }