TripService we can refactor as much as we want because everything is under test.

Creating validate method.

diff --git a/TDD/src/main/java/org/craftedsw/tripservicekata/trip/TripService.java b/TDD/src/main/java/org/craftedsw/tripservicekata/trip/TripService.java
index bd899a2..276710f 100644 (file)
--- a/TDD/src/main/java/org/craftedsw/tripservicekata/trip/TripService.java
+++ b/TDD/src/main/java/org/craftedsw/tripservicekata/trip/TripService.java
@@ -18,15 +18,19 @@ public class TripService {
        }\r
 \r
        public List<Trip> getTripsByUser(User user, User loggedInUser) throws UserNotLoggedInException {\r
-               if (loggedInUser == null) {\r
-                       throw new UserNotLoggedInException();\r
-               }\r
+               validate(loggedInUser);\r
                \r
                return user.isFriendsWith(loggedInUser)\r
                                ? tripsBy(user)\r
                            : noTrips();\r
        }\r
 \r
+       private void validate(User loggedInUser) {\r
+               if (loggedInUser == null) {\r
+                       throw new UserNotLoggedInException();\r
+               }\r
+       }\r
+\r
        private ArrayList<Trip> noTrips() {\r
                return new ArrayList<>();\r
        }\r